Skip to content

📝 Adds reference to sample repo demonstrating HMR #1042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 8, 2019
Merged

📝 Adds reference to sample repo demonstrating HMR #1042

merged 2 commits into from
Nov 8, 2019

Conversation

edelgado
Copy link
Contributor

@edelgado edelgado commented Nov 7, 2019

Summary

Adds a link to a sample Rails app that demonstrates HMR working with react-rails and adds a note of the present incompatibility of SSR and HMR.

@edelgado edelgado mentioned this pull request Nov 7, 2019
Closed
@BookOfGreg
Copy link
Member

The SSR HMR incompatibility shouldn't be that hard to sort out I believe, I've just never sat down to sort it.
There are certainly other folks doing it:
https://github.com/mavajee/example__react-ssr-with-hmr
Anyway until I get that sorted thank you for contributing this.

@BookOfGreg BookOfGreg merged commit 94f7897 into reactjs:master Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edelgado @BookOfGreg